search

microsoft / vscode-docker

Docker Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-docker
Other
1.19k stars 508 forks source link

There is an extra "Disconnect" action in the context menu of the "Generic Registry V2" registry #4160

Closed v-xinda closed 7 months ago

v-xinda commented 7 months ago

OS: All Build Version: 20231107.2 Regression: Previous release (1.27.0)

Repro Steps:

  1. F1 -> Click "Docker Registries: Connect Registry..." -> Click "Generic Registry V2" registry -> Type "http://localhost:5100/" -> Type a name and password.
  2. Navigate to the "Registries" view -> Right click "Generic Registry V2" registry.
  3. Check whether there is no "Disconnect" action in the context menu.

Expect: There is no "Disconnect" action in the context menu.

Actual: There is an extra "Disconnect" action in the context menu. image

More Info:

  1. There is no "Disconnect" command for the "Generic Registry V2" registry in the command palette.
  2. There is an error prompt when connecting "Generic Registry V2" registry using the "http://localhost:5100/" again, if disconnect "Generic Registry V2" registry using "Disconnect" action from the context menu. image
bwateratmsft commented 7 months ago

This was added intentionally to fix #4140.

v-xinda commented 7 months ago

@bwateratmsft It is not convenient, we need to connect "Generic Registry V2" registry using another URI, if I disconnect "Generic Registry V2" registry (Connect with "http://localhost:5100/" URI) from its context menu.

bwateratmsft commented 7 months ago

Hm, I'm not getting the "Already connected" warning. I need to look into this.

bwateratmsft commented 7 months ago

After testing it's looking like everything is working as expected now. The extra "Disconnect" option is awkward but the only way to work around #4140.