search

microsoft / vscode-docker

Docker Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-docker
Other
1.18k stars 508 forks source link

Connecting to generic v2 registry is failing #4245

Open pWoLiAn opened 4 months ago

pWoLiAn commented 4 months ago

using latest extension version. When connecting to registry, get the message "fetch failed" image im able to pull using CLI image EDIT: the extension works properly with the previous version(1.28). issue is seen only with the latest version(1.29)

vscode details: Version: 1.86.2 (user setup) Commit: 903b1e9d8990623e3d7da1df3d33db3e42d80eda Date: 2024-02-13T19:40:56.878Z Electron: 27.2.3 ElectronBuildId: 26908389 Chromium: 118.0.5993.159 Node.js: 18.17.1 V8: 11.8.172.18-electron.0 OS: Windows_NT x64 10.0.22631

running on ubuntu 20.4 with remote SSH

bwateratmsft commented 4 months ago

Try removing the /v2 from your registry URL, the extension adds that automatically as needed.

pWoLiAn commented 4 months ago

still failing with the same error

bwateratmsft commented 4 months ago

Can you tell me more about your registry provider? It may not be supported by the generic V2 registry connection.

pWoLiAn commented 4 months ago

What type of information do you need? Although i dont think this is an issue with the registry because I'm able to connect to it normally with version 1.28.

bwateratmsft commented 4 months ago

That's helpful to know. I think the most likely change that could have caused this is https://github.com/microsoft/vscode-docker-extensibility/commit/24e2d357bf481dd5e7f0636734187a41234cce0d, we changed from using node-fetch to the built-in fetch in Node.js 18. Are you using a proxy?

pWoLiAn commented 4 months ago

yes i am

bwateratmsft commented 4 months ago

Are you able to test without the proxy in place? It would be helpful to know for sure if the issue is something to do with the proxy.

pWoLiAn commented 4 months ago

i cannot access the registry without the proxy but i can try using a different proxy

westy commented 4 months ago

I'm getting the same issue. It was working with a previous version of the extension, and now it's not. I suspect it might be something to do with the cert on the private registry (hosted on a local linux server) being self-signed?

The certificate is installed as a trusted CA on the machine, and I can browse to it fine in a web browser.

Is there any logging for the extension that I can look at perhaps?

Cheers

bwateratmsft commented 4 months ago

That's very helpful to know. @pWoLiAn does your registry also use a self-signed certificate?

pWoLiAn commented 4 months ago

yes

fengjianxincoke commented 2 months ago

I had the same problem with my mac, vs code version: 1.88.1 docker plugin version: 1.29.0 I can't connect to docker hub registried ![Uploading WechatIMG149.jpg…]()

TorchDSP commented 2 months ago

Our current workaround is to use version v1.28.0. Otherwise getting the fetch failed message. Tried v1.29.1 this morning. Same issue as found with v1.29.0.

What we have seen is that with the newer versions it doesn't seem to reach out to the remote server. We don't see any new logs in the registry container. With v1.28.0 we see the GET transaction.

After more diagnosis, the fetch actually isn't being done on a consistent basis. No packets across the network and the plugin just declares the fetch failed. We are not using self-signed certificates.

tonimore commented 1 month ago

I confirm that 1.28.0 working fine and 1.29.1 doesn't