search

microsoft / vscode-docs-authoring

VSCode extension that provides markdown authoring assistance to docs.microsoft.com contributors
MIT License
139 stars 89 forks source link

CTRL+SHIFT+P -> Docs: Snippet command inserts invalid markup when using Id #470

Closed jasonjoh closed 4 years ago

jasonjoh commented 4 years ago

docs-markdown version 0.2.59, using Visual Studio Code Insiders 1.44.0-insiders

Steps to reproduce:

  1. CTRL+SHIFT+P, choose Docs: Snippet
  2. Choose Full Search
  3. Enter a valid file name to a code file in the repository
  4. Choose the file
  5. Choose Id
  6. Enter a value for the snippet ID

The resulting markup that's inserted is missing a double-quote in front of the snippet ID, which causes the build to fail.

Example (note that MySnippet should have a leading double-quote):

:::code language="csharp" source="../demo/GraphTutorial/Program.cs" id=MySnippet":::
bharney0 commented 4 years ago

@jasonjoh Thank you for reporting this problem. We have reproduced this bug and will fix the problem as soon as possible. We will reach out to you if we have more questions. Internally tracking work with AzureDevOps ticket 190675

bharney0 commented 4 years ago

Bug fix done on PR #474