search

microsoft / vscode-docs-authoring

VSCode extension that provides markdown authoring assistance to docs.microsoft.com contributors
MIT License
138 stars 90 forks source link

Confusing messages for docs-images #766

Open mairaw opened 3 years ago

mairaw commented 3 years ago

I've been running the extension on the .NET website images. Sometimes, we get an error message that is unable to compress an image, but then right after it says successfully compressed, which seems incorrect since no changes are applied. I imagine that if we get the unable to compress message, then the successful message shouldn't be displayed.

Attempting to compress "c:\Users\mairaw\Documents\GitHub\website\src\netlandingpage\wwwroot\static\images\aspnet-book-covers\aspnet-core-1.1-building-web-api-for-beginners.png".
Using .png compression plugin for: "c:\Users\mairaw\Documents\GitHub\website\src\netlandingpage\wwwroot\static\images\aspnet-book-covers\aspnet-core-1.1-building-web-api-for-beginners.png"
Unable to compress "aspnet-core-1.1-building-web-api-for-beginners.png".
Successfully compressed file:///c:/Users/mairaw/Documents/GitHub/website/src/netlandingpage/wwwroot/static/images/aspnet-book-covers/aspnet-core-1.1-building-web-api-for-beginners.png.

AB#320986

IEvangelist commented 3 years ago

Hi @mairaw - to be clear, when you get the conflicting messages does it actually end up compressing the image? I think there is a delay built in and it times out after a bit, but I could look into this. Curious, are you able to share this exact image so that I could try to recreate the issue locally?

mairaw commented 3 years ago

No, it doesn't compress. The exact image is in the error message. I believe you have a copy of the website source. 😉