search

microsoft / vscode-docs-authoring

VSCode extension that provides markdown authoring assistance to docs.microsoft.com contributors
MIT License
138 stars 97 forks source link

Linter for self-definable baselines in simplified language. #910

Closed bobbytreed closed 1 year ago

bobbytreed commented 2 years ago

Good Morning, I'm sure this will be a long process, but I wanted to get it started and see what I need to do next. This is a linter built for ingesting baselines defined in a simple json schema (ingestion still a work in progress), in the meantime it successfully lints MVC, Horizontals content including importing includes.

Uploading vlc-record-2021-08-05-11h06m28s-[Extension Development Host] - create-custom-policy-definition.md - automation - Visual Studio Code-.mp4…

bharney0 commented 2 years ago

@bobbytreed Thank you for your contribution! I did have a few questions about this PR. Can you provide more context on what these changes are? Possibly a gif and how to test the changes? Also it looks like there is a merge conflict in the package.json.

cc @IEvangelist @meganbradley @lamebrain

IEvangelist commented 2 years ago

Hi @bharney0 - I was collaborating with Bobby and a few others on this effort. With that said, this was a huge port. Essentially, Bobby has had tooling (in .NET) in place for years now that is capable of deeply understanding markdown hierarchies as it relates to our contributor guidance. He could reason about various things, such as "this MD file is this type, so it requires a specific section" for example. And from there it gets a lot more granular, the level of control is seemingly infinite. @bobbytreed can provide more context, and details.

bharney0 commented 1 year ago

@bobbytreed @IEvangelist just wanted to keep you guys posted. There was a lot of feedback from the Authoring Pack Extensions that fell by the wayside over the last year. And we felt like there was no feedback mechanism for the community about the Extensions. With numerous problems and lack of resources, we will be trying to stabilize the Extension Pack over the next few weeks. We are unarchiving this repo, and removing the code to allow users to report issues. But will not be taking open source contributions. The actual code will live in ADO and will be maintained by the authoring team.

As for this extension and PR, I will be closing this. I would discuss with @meganbradley about getting the linter extension in front of authors.

Without a doubt we could have been more transparent, and left you guys in a lurch. Sorry if we sent the wrong message by suddenly close sourcing this project without communicating to the community.