search

microsoft / vscode-docs

Public documentation for Visual Studio Code
http://code.visualstudio.com/docs
Other
5.69k stars 4.62k forks source link

A11y_code.visualstudio.com_DownloadInsiders_AI4W: The “Get the latest release each day.” and “Read more in the blog...” texts are provided with unnecessary heading elements. #2795

Closed MayuriNaik closed 5 years ago

MayuriNaik commented 5 years ago

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

GitHub Tags: #A11yMAS #CAITestPass_June’19 #Win10 #DesktopWeb #AI4W #WCAG2.4.6 #Edge #Chrome

Environment Details: URL: https://code.visualstudio.com Windows Version: Windows10 Browser Version: Microsoft Edge 42.17134.1.0 Chrome Version 75.0.3770.100 (Official Build) (64-bit) Screen Reader Versions : NVDA2019.1.1 Standard Violated : WCAG 2.4.6

Repro Steps:

  1. Launch the application.
  2. Navigate to "Download" button.
  3. Scroll down the page and hit "Insiders build" link.
  4. Navigate through the "Download Insiders" screen.
  5. Navigate to “Get the latest release each day.” and “Read more in the blog...” texts.
  6. Observe if these texts are provided with heading or not.

Actual: The “Get the latest release each day.” and “Read more in the blog...” texts are provided with heading elements of level 3 which is incorrect as these texts are defining any specific section on the screen.

Expected: when screen reader users navigate to the “Get the latest release each day.” and “Read more in the blog...” texts, they should not be announced as heading elements.

User Impact: If some text on the screen are provided with heading elements unnecessarily then the screen reader users might not understand the screen content structure.

Attachment for Reference: Code visualstudio com_DownloadInsiders_K4W Unnecessary heading elements

octref commented 5 years ago

which is incorrect as these texts are defining any specific section on the screen

If you meant "aren't defining any specific section on the screen", I don't think it violates the MAS guideline, which states:

When headings and labels are used, they must describe the topic or purpose of the element or content that they pertain to.

“Get the latest release each day.” describes the purpose of this page. “Read more in the blog...” describe the purpose of the "blog" link.