search

microsoft / vscode-docs

Public documentation for Visual Studio Code
http://code.visualstudio.com/docs
Other
5.66k stars 4.6k forks source link

Home page download buttons incorrect placement on mobile #7476

Closed keyboy21 closed 2 months ago

keyboy21 commented 2 months ago

Screenshot_2024-08-01-23-51-03-113_org mozilla firefox

ntrogh commented 2 months ago

@yusuf-saydullayev thanks for bringing this up. Can you provide details about the specific mobile device, OS, and browser you're experiencing this on?

keyboy21 commented 2 months ago

OS: Android 14 Browser: Firefox 128.0.3. In Chrome (v127) same too.

ntrogh commented 2 months ago

@daviddossett seems to be a case where OS detection flags as neither Windows, Linux, or macOS and decides to show all three.

daviddossett commented 2 months ago

Can't seem to repro this but I did try to clean up the logic a little bit in https://github.com/microsoft/vscode-website/pull/1872

Since the default is to display: none and to only render buttons when they match a certain data-os attribute, it seems like the CSS isn't getting applied somehow.

ntrogh commented 2 months ago

You can repro by setting the user agent to some random text.

daviddossett commented 2 months ago

Thanks, that worked. I see home win linux osx applied as classes on body now. Not sure why that would be happening though. cc @rzhao271 for any other ideas