search

microsoft / vscode-edge-debug2

This is a VS Code extension which helps you debug your JavaScript Code inside the Edge browser.
Other
37 stars 31 forks source link

Rework targeted webview debug code to work after about:blank change #181

Closed DavidShoe closed 4 years ago

DavidShoe commented 4 years ago

Changed code to now watch for navigation events and look for the targeted url. Once found we activate the debugging mode over the correct port.

Also some lint cleanups

EricCornelson commented 4 years ago

Also, @DavidShoe, I'm having trouble testing these changes locally. Using the WebView2APISample code, I'm getting the following error:

image

Any insight on what might be the issue?

DavidShoe commented 4 years ago

I think they were auto generated, when I did a “gulp build”, the loc files changed I suspected that it isn’t the right way to update them (especially with the warnings about missing strings).

I can revert those changes.

From: Eric Cornelson notifications@github.com Sent: Wednesday, April 15, 2020 5:34 PM To: microsoft/vscode-edge-debug2 vscode-edge-debug2@noreply.github.com Cc: David Shoemaker David.Shoemaker@microsoft.com; Author author@noreply.github.com Subject: Re: [microsoft/vscode-edge-debug2] Rework targeted webview debug code to work after about:blank change (#181)

@EricCornelson commented on this pull request.

In package.nls.cs.jsonhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvscode-edge-debug2%2Fpull%2F181%23discussion_r409204222&data=02%7C01%7CDavid.Shoemaker%40microsoft.com%7Ce5b7d70ea469454b425008d7e19dcf56%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637225940236236365&sdata=eK%2BPNmXXC0tjt2MNdDTPY%2B74V%2FIFauMwCuAbhSsKifE%3D&reserved=0:

@@ -1,33 +1,35 @@

{

Where did these translations come from?

If we have missing translations, I can reach out to our localization lead. I'm not sure these nls files are actually used in the final packaged build

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvscode-edge-debug2%2Fpull%2F181%23pullrequestreview-394215226&data=02%7C01%7CDavid.Shoemaker%40microsoft.com%7Ce5b7d70ea469454b425008d7e19dcf56%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637225940236236365&sdata=zQBoNAgbCEvKqQYUM0k6DH5ZMAnuDmqhu8YmTbnHpYQ%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAC37EW24XR52BZCA7UJ334LRMZG6HANCNFSM4MIDFBLQ&data=02%7C01%7CDavid.Shoemaker%40microsoft.com%7Ce5b7d70ea469454b425008d7e19dcf56%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637225940236246362&sdata=r0Q%2FsRH8bczP5j3SzcgtWOSHGsBXBak9GR1mQTFKzvc%3D&reserved=0.