search

microsoft / vscode-emmet-helper

A helper module to use emmet modules with Visual Studio Code
MIT License
39 stars 32 forks source link

Debt: Check how syntaxConfig is being accessed #49

Closed rzhao271 closed 3 years ago

rzhao271 commented 3 years ago

We have upstream: https://github.com/emmetio/emmet/blob/master/src/config.ts#L353 Which we access in this repo in this function: https://github.com/microsoft/vscode-emmet-helper/blob/main/src/emmetHelper.ts#L399, which defaults the stylesheet syntax to use to CSS.

To look into: do we need to default the syntaxToUse to CSS?

rzhao271 commented 3 years ago

Answer: we don't need to default the syntax used in emptyConfig to CSS for stylesheet languages. Therefore, we can pass syntax directly to emptyConfig.

To verify: code review.