microsoft / vscode-emmet-helper

A helper module to use emmet modules with Visual Studio Code
MIT License
39 stars 32 forks source link

fix: doComplete result may be undefined #51

Closed johnsoncodehk closed 3 years ago

johnsoncodehk commented 3 years ago

I highly recommend add "strict": true to tsconfig and fix all the typescript error.

rzhao271 commented 3 years ago

Yeah, I noticed that there's many errors that show up once "strict": true has been enabled.

johnsoncodehk commented 3 years ago

other typescript errors is not a real problem, it was just to make sure the code conforms to typescript logic.

but doComplete return type is a problem if it inaccurate, and this problem make a bug to me :(

https://github.com/johnsoncodehk/volar/issues/65