search

microsoft / vscode-emmet-helper

A helper module to use emmet modules with Visual Studio Code
MIT License
39 stars 32 forks source link

Notification handler 'workspace/didChangeConfiguration' failed with message #64

Closed X-DCB closed 1 year ago

X-DCB commented 3 years ago

I always check for updates but I already got the latest update and still, the error shows up. emmetExtensionsPath.trim is not a function

rzhao271 commented 3 years ago

@X-DCB if you open your settings file in the JSON editor (workbench.action.openSettingsJson command), what do you get for emmetExtensionsPath?

Here's generally how mine looks:

"emmet.extensionsPath": [
    "C:\\Users\\<username>\\<rest-of-path>"
]
X-DCB commented 3 years ago

sorry for the delay 😅 i installed VS code insider and sometimes the error pops up image

rzhao271 commented 3 years ago

Hm, looks like it's an empty array. Can you check in the settings JSON file to confirm that's the case? Also, when does the error message show up for you?

X-DCB commented 3 years ago

Hm, looks like it's an empty array. Can you check in the settings JSON file to confirm that's the case? Also, when does the error message show up for you?

what should be the array values, I mean what are the target locations?

rzhao271 commented 3 years ago

If you're not using snippets, an empty array is fine. I'm curious whether the value is being saved differently in the settings json file, though? Can you run the workbench.action.openSettingsJson command and see if there's an entry for emmet.extensionsPath? If that entry exists, can you paste me the value?

rzhao271 commented 3 years ago

I'll close this issue for now as part of the housekeeping iteration. If you have some answers for https://github.com/microsoft/vscode-emmet-helper/issues/64#issuecomment-914421549 I can re-open the issue.

CherryDT commented 1 year ago

@rzhao271 I'm having the same problem, this issue still exists. For me, emmet.extensionsPath is simply not existing at all (undefined) if it never got anything set. But even if I manually add it as empty array to the remote settings JSON file, nothing changes.

I get this error while opening *.edge template files by the way. I'm using Remote WSL1.

wearon commented 1 year ago

I can't believe I'm still facing this, its been months now. I even added "emmet.extensionsPath": ["/Users/snippets.json"] but same error and the sock in the bottom keeps switching to Output from Terminal 😡

image
rzhao271 commented 1 year ago

Closing because VS Code has picked up the latest emmet-helper package. @wearon is the issue resolved for you on the latest VS Code Insiders? The change has not made it to Stable yet.

rzhao271 commented 1 year ago

Verification steps:

  1. Set the emmet.extensionsPath setting to [2] in the settings JSON file.
  2. Open devtools.
  3. Verify that a console warning shows up.
wearon commented 1 year ago

when you say "Open devtools" in vscode, what is there referring to? Just upgraded to latest insiders, pasting settings json + error + vscode version below

image
rzhao271 commented 1 year ago

"Open devtools" refers to running the "Developer: Toggle Developer Tools" command. The logged warning, if there is one, should start with "The following emmetExtensionsPath isn't a string: "

If there isn't such a warning, I have another hypothesis. The output pane seems to come from another extension starting with the word "EDGE Language". That extension, if they're using this library, might need to pick up the latest @vscode/emmet-helper package.

wearon commented 1 year ago

Thanks for sharing your hypothesis, there is this plugin with a dependency, I think this might be it. is it possible for you to install it and see if it triggers a warning?

image
rzhao271 commented 1 year ago

I confirmed that https://github.com/duyluonglc/vscode-edge/ is using an outdated version of vscode-emmet-helper. Please file an issue there.