microsoft / vscode-emmet-helper

A helper module to use emmet modules with Visual Studio Code
MIT License
39 stars 32 forks source link

fix: merge attributes before passing them upstream #87

Closed rzhao271 closed 1 year ago

rzhao271 commented 1 year ago

Ref downstream PR https://github.com/microsoft/vscode/pull/185607

Emmet added some new object properties, but the upstream merging algorithm makes it so that if a user only defines some keys to customize, the other keys within that same property are erased.

This PR works around the issue by merging the properties with the upstream defaults, and then passing in that entire object upstream so that the default object gets overridden with the larger object.