microsoft / vscode-eslint

VSCode extension to integrate eslint into VSCode
MIT License
1.73k stars 335 forks source link

Feature request: show notification when ESLint fails to load #1807

Open OliverJAsh opened 7 months ago

OliverJAsh commented 7 months ago

The status of ESLint is indicated in the status bar by the tiny x symbol:

image



This is very difficult to spot. I want to be alerted as soon as there's an issue. Could we send a notification when ESLint fails to load?

For context, I encounter these errors quite frequently because my ESLint config depends on custom rules that need to be built prior to ESLint running. A notification would serve as a useful reminder that I need to build my custom lint rules.

dbaeumer commented 7 months ago

We had notifications in the past and move to language status since notifications are annoying if you open workspaces where you can't fix this. So if we bring notifications back it has to go behind a setting.

U-4-E-A commented 6 months ago

We had notifications in the past and move to language status since notifications are annoying if you open workspaces where you can't fix this. So if we bring notifications back it has to go behind a setting.

In terms of notifying, I find the way prettier does it more than suffices to draw the person's attention to the fact there is an issue, which can then be debugged in output.

image

dbaeumer commented 6 months ago

VS Code's recommendation for something like this is to use a language status.

Image

If every extension has its own status indicator this will look very crowded.

U-4-E-A commented 6 months ago

The user can select which indicators they wish to see? I would also consider eslint - along with prettier - to be perhaps the 2 most import for a developer to be able to monitor while working.

Also a split between soft errors (current file not included) and hard errors (eslint crashing/failing to configure) would very helpful.

dbaeumer commented 6 months ago

Yes, the user can ping the ESLint indicator to the status line.