search

microsoft / vscode-eslint

VSCode extension to integrate eslint into VSCode
MIT License
1.74k stars 335 forks source link

Restarting an extension when that extension's output is selected in the "Output" pane should not change which extension is selected in the "Output" pane. #1898

Open GageSorrell opened 3 months ago

GageSorrell commented 3 months ago

Current Behavior

Suppose the "Output" pane is visible, and a given extension's output is being viewed.

If the user runs the "Restart" command for that extension (for example, the TypeScript LSP, or the ESLint extension), the selected extension of the "Output" pane changes.

Statement of Issue

If a user restarts an extension and is viewing the output of that extension, they almost certainly will want to see the output of the extension upon restarting the extension.

Proposed Behavior

When restarting an extension, I propose that the selected extension in the "Output" pane remain unchanged.

sandy081 commented 3 months ago

I am not able to reproduce this. Can you please provide the exact steps to repro?

GageSorrell commented 3 months ago
  1. Open a Workspace that has the ESLint extension enabled (I have also tested this with the TypeScript LSP)
  2. Focus the "Output" pane, then choose ESLint from the dropdown menu
  3. Ctrl+P, then select the "Restart the ESLint server" command

Once this is done, the value of the dropdown menu changes (for me) to the output of "Tasks", which seems to be arbritrary.

sandy081 commented 3 months ago

This seems to be an issue with eslint extension. It might be disposing the chanel and creating it again on restarting the ES Lint Server. When an output channel is disposed a default channel is shown.