search

microsoft / vscode-extension-samples

Sample code illustrating the VS Code extension API.
MIT License
8.84k stars 3.45k forks source link

Update javascript target from es6 to ES2019 #265

Closed J-Fields closed 4 years ago

J-Fields commented 4 years ago

For a while now, VSCode has shipped with node 12, which according to the typescript wiki can handle ES2019.

I may be missing something (I'm far from an expert on this stuff), but is there a reason that the extension samples here still transpile to es6? Would you recommend new extensions target es6?

usernamehw commented 4 years ago

Does it mean that it's completely safe to use target ES2019 for vscode engine 1.40.0 and higher?

KamasamaK commented 4 years ago

Does it mean that it's completely safe to use target ES2019 for vscode engine 1.40.0 and higher?

That would make sense based on the Node compatibility chart, but I wonder if there are scenarios where browser compatibility would be an issue. I've never tried it, but I know Visual Studio Codespaces exists and presumably has some minimum browser requirements but couldn't find anything on it.