microsoft / vscode-extension-telemetry

Node module to help VS Code extensions send telemetry using application insights
https://www.npmjs.com/package/@vscode/extension-telemetry
Other
126 stars 46 forks source link

Common properties not sent when properties parameter is undefined in sendTelemetryEvent #149

Closed jwunderl closed 1 year ago

jwunderl commented 1 year ago

Telemetry events sent through TelemetryReporter.sendTelemetryEvent with just the eventName parameter (/ undefined for properties) do not include the common properties like common.extname; e.g. comparing two ticks

tr.sendTelemetryEvent("shareProject");

image

vs.

tr.sendTelemetryEvent("duplicateAsset", {});

image

I would expect it to always fill in the common properties.

Thanks~

lramos15 commented 1 year ago

Thanks for the report, if you get a chance please verify this works as expected in Mondays insiders build. The fix is upstream so you will not need to update your module at all.