search

microsoft / vscode-extension-telemetry

Node module to help VS Code extensions send telemetry using application insights
https://www.npmjs.com/package/@vscode/extension-telemetry
Other
125 stars 46 forks source link

Fix send raw telemetry #172

Closed lramos15 closed 1 year ago

lramos15 commented 1 year ago

Fixes https://github.com/microsoft/vscode-extension-telemetry/issues/171

andyleejordan commented 1 year ago

Looks like this changed requires a VS Code engine update. Do you know what minimum version now? We're stuck on 1.79.0 until Azure Data Studio updates.

andyleejordan commented 1 year ago

Looks like 1.81.1: https://github.com/microsoft/vscode/commit/64eef4cec182e33007a5366576d139620a656dc8

Might want to consider a minor version bump instead of patch, or if there's a way to hide this implementation detail from consumers.

lramos15 commented 1 year ago

Looks like this changed requires a VS Code engine update. Do you know what minimum version now? We're stuck on 1.79.0 until Azure Data Studio updates.

That surprises me.

We're using the telemetry API from the entire module which was introduced in the January release (1.75)

Here's the PR. The commit you posted is also from January which means it made it into 1.75 https://github.com/microsoft/vscode/pull/171858/files#diff-0a75aed19c118603eb96332bc0b9c2d7867f4182346d16d18b7fc31b6ceeb321R16689-R16693