microsoft / vscode-generator-code

Visual Studio Code extension generator
Other
1.29k stars 222 forks source link

Template consistency pass #360

Closed hawkticehurst closed 2 years ago

hawkticehurst commented 2 years ago

Resolves #359

Includes the following changes:

hawkticehurst commented 2 years ago

cc @daviddossett / @misolori / @aeschli

hawkticehurst commented 2 years ago

Looks like CI testing failed because gitattribute (no dotfile) is part of the test suite (so I'm happy to revert my changes on that).

But I suppose it's a good time to double-check why only some of gitignore, gitattribute, and vscodeignore files are dotfiles and others are not?

aeschli commented 2 years ago

Update all gitignore, gitattribute, and vscodeignore that are not dotfiles to be dotfiles

That also requires updating the generator scripts. Note: the user never saw the dotless files.

hawkticehurst commented 2 years ago

That also requires updating the generator scripts. Note: the user never saw the dotless files.

Ahh, thanks for clarifying and for contributing a change to address this!