Fix .gitignore files not included in npm package

microsoft / vscode-generator-code

Visual Studio Code extension generator

Other

1.31k stars 225 forks source link

Fix .gitignore files not included in npm package #364

Closed mboultoureau closed 2 years ago

mboultoureau commented 2 years ago

Fix #363 : missing .gitignore files in NPM Package. Rename .gitignore files to gitignore and change the copy instructions.

.gitgnore files cannot be included in packages (https://github.com/npm/npm/issues/3763).

ghost commented 2 years ago

All CLA requirements met.

danawoodman commented 2 years ago

Tagging maintainers @hawkticehurst @aeschli @joyceerhl: this bug is breaking setup for every user using this generator so seems pretty critical to merge

bpasero commented 2 years ago

Thank you!

hawkticehurst commented 2 years ago

Ah! I was out of the office when this happened and am finally catching up on old issues now. Thank you so much for the fix @mboultoureau (and @danawoodman for the call out) 🙏