fixes glob configuration and usage

microsoft / vscode-generator-code

Visual Studio Code extension generator

Other

1.29k stars 222 forks source link

fixes glob configuration and usage #428

Closed baywet closed 11 months ago

baywet commented 1 year ago

fixes how glob is being used
removes obsolete type definitions
renames webpack config to .cjs

aeschli commented 1 year ago

We can use Node16 as module. That way the exports declarations are used.

Is there an urge to rename the webpack config to .cjs?

baywet commented 1 year ago

@aeschli thanks for reverting back to me. No urge on the cjs thing for now. I can rebase and drop that commit if you want. But I thought it was forward looking (unless you're planning to rewrite it ES style). For node16 are you referring to module or module resolution or both?

aeschli commented 11 months ago

Replaced by https://github.com/microsoft/vscode-generator-code/pull/429/