Add bun support as a package manager

microsoft / vscode-generator-code

Visual Studio Code extension generator

Other

1.3k stars 224 forks source link

Add bun support as a package manager #475

Open kravetsone opened 5 months ago

kravetsone commented 5 months ago

Description

This PR adds support for bun as a package manager.

Changes

Based on the existing tests, I've created additional tests to validate support for bun with all relevant templates.

Checklist

[x] Tests cover bun usage
[x] CLI help has been updated to include bun
[x] CLI prompt has been updated to include bun
[x] Readme has been updated to include bun
[x] Wait when https://github.com/yeoman/environment/pull/532 will be merged
[x] Wait new version of yeoman/environment

kravetsone commented 5 months ago

@kravetsone please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

@microsoft-github-policy-service agree

aeschli commented 5 months ago

Please check with us first if we want a feature, before investing work in a PR that we might not take.

I haven't used bun myself, but from what I read, it's most of all a new runtime, that also comes with a package manager. Isn't it confusing to use bun as package manager when the runtime is NodeJS? Note that the yo code generator is mostly for new users. and we want to keep things as simple as possible.

If all that's needed is to replace npm with bun, that's quite easy to do with find/replace. No need to make the yo code generator more complex.

kravetsone commented 5 months ago

Isn't it confusing to use bun as package manager when the runtime is NodeJS?

I don't think so. Bun as a package manager only is already used in a huge number of repositories.

Why shouldn't he be on the list? Who knows, he will choose. Moreover, yoeman is now execute bun install (but the release has not yet been released)

No need to make the yo code generator more complex.

Does that make it harder? The usual choice is the same as between npm/yarn/pnpm...

kravetsone commented 5 months ago

yeoman/environment@4.4.1 with Bun install released.

Do I need to bump the version in dependencies?