microsoft / vscode-generator-code

Visual Studio Code extension generator
Other
1.3k stars 224 forks source link

generated settings.json refers to output as out instead of dist #479

Closed jonahgraham closed 5 months ago

jonahgraham commented 5 months ago

If I run yo code the settings.json file refers to out for files.exclude and search.exclude when I believe it should be dist (both the setting and the comment on the same line)

Here is what I ran:

$ npx --package yo --package generator-code -- yo code

     _-----_     ╭──────────────────────────╮
    |       |    │   Welcome to the Visual  │
    |--(o)--|    │   Studio Code Extension  │
   `---------´   │        generator!        │
    ( _´U`_ )    ╰──────────────────────────╯
    /___A___\   /
     |  ~  |     
   __'.___.'__   
 ´   `  |° ´ Y ` 

? What type of extension do you want to create? New Web Extension (TypeScript)
? What's the name of your extension? extensionname
? What's the identifier of your extension? extensionname
? What's the description of your extension? 
? Initialize a git repository? Yes
? Which bundler to use? esbuild
? Which package manager to use? yarn

I think this is where the value comes from:

https://github.com/microsoft/vscode-generator-code/blob/772b7922b8ae71bdba24a50fb18c760f76d2b1ba/generators/app/templates/ext-command-web/vscode-esbuild/settings.json#L3-L7