search

microsoft / vscode-go

An extension for VS Code which provides support for the Go language. We have moved to https://github.com/golang/vscode-go
Other
5.93k stars 645 forks source link

Raise error if GOOS/GOARC is not compatible with host machine in debug #3218

Closed bulentkazanci closed 4 years ago

bulentkazanci commented 4 years ago

As it is specified on the issue of #2696, while debugging an application, if GOOS or GOARCH value under go.toolsEnvVars is specified a value different than the host machine value, a nonexplanatory error is raised. The changes in this PR compares both environment variables with the ones on the host machine, if there is an incompatibility, it raises a meaningful error.

Closes #2696

A show case on mac: goos-check

ramya-rao-a commented 4 years ago

Hey @bulentkazanci

Looks like this is your first PR contribution to this project, Thanks & Welcome!

Unfortunately, we are in the midst of a repo move, see We are moving section in our readme for more details.

We will have to close this PR as we are not accepting any PRs at the moment unless it is related to the move or critical bug fixes. Please consider creating this PR in the new home i.e https://github.com/golang/vscode-go.

Also, on a side note, see https://github.com/microsoft/vscode-go/issues/2696#issuecomment-631265774. I believe we are yet to reach an agreement on the best course of action for this issue.