Search not re-evaluated after file modification

[josephH00]

When a file opened in the hex editor is changed from either inside or outside VS Code, the search results are not re-evaluated and retain the results and position from the older file. I've attached two screenshots below showing the behavior.

Before modification:

After modification:

[karthiknadig]

I don't see a pre-release version for this with the fix.

[DonJayamanne]

@mjbvz out of curiosity, where did you get the VSIX for this?

[mjbvz]

@DonJayamanne I add verified when I start verifying so others don't grab them. In this case I couldn't verify so I then unmarked it

[karthiknadig]

This still exists using the current main branch build:

It looks like the search does not reevaluate as you type as well.

[aiday-mar]

We probably need a new label of type under-verification so the issue is not verified in parallel by two different people. I will add that label.

@connor4312 I am pinging about the milestone for this issue. We have branched off from the main branch recently. Would you like to make this issue a candidate or move it out to the March 2024 milestone?

[connor4312]

We probably need a new label of type under-verification so the issue is not verified in parallel by two different people. I will add that label.

@aiday-mar the practice is to add verified when you start verifying and remove it if verification fails. That will also prevent the issue showing up in queries

It looks like the search does not reevaluate as you type as well.

This is intended, searching can be pretty expensive and we don't want to do it on each character entry. Re-closing for verification, search should only be re-run if the file is changed externally.