search

microsoft / vscode-hexeditor

VS Code Hex Editor
https://marketplace.visualstudio.com/items?itemName=ms-vscode.hexeditor
MIT License
525 stars 85 forks source link

add some cjk encoding support for Data Inspector. #464

Closed liudonghua123 closed 7 months ago

liudonghua123 commented 10 months ago

Hi, I like this extension, it's awesome. But sometimes the bytes in the file could not decode as some cjk encoding like gbk.

It would be nice to support this feature.

And I go through the code and find maybe I can add gbk support like utf-8 in media/editor/dataInspectorProperties.tsx.

https://github.com/microsoft/vscode-hexeditor/blob/3bad0a5e071a3393d36f73f4f8d4022d228d8ce2/media/editor/dataInspectorProperties.tsx#L75-L83

liudonghua123 commented 10 months ago

I added gb18030 support. See the snapshot below. It seems work for me.

image