Closed liudonghua123 closed 7 months ago
I do worry that this will make the data inspector fairly long. I wonder if there's a way we can support all the formats that the TextDecoder supports without adding a bunch of these
I do worry that this will make the data inspector fairly long. I wonder if there's a way we can support all the formats that the TextDecoder supports without adding a bunch of these
Yeah, an interactive select
element which includes all supported encoding of TextDecoder as options maybe an elegant way.
However, the datatype decode is quick and low resource consumption. And there are a lot remaining free spaces there, so maybe not a problem right now.
Could you please also add Shift-JIS? I believe it's pretty common in a lot of JP executables.
From the docs on Encodings of Japanese. It seems shift-jis
is more suitable then euc-jp
. I will update the code for pr.
And for Korean, iso-2022-kr
seems more suitable then euc-kr
, from https://www.rfc-editor.org/rfc/rfc1557.html.
IMHO, maybe it would be better to allow users to customize encoding(s) to use in configuration file? 或者说,从配置文件读取需要的编码是否会更好?
Closes https://github.com/microsoft/vscode-hexeditor/issues/464.