Add hover byte status - Githubissues

microsoft / vscode-hexeditor

VS Code Hex Editor

https://marketplace.visualstudio.com/items?itemName=ms-vscode.hexeditor

MIT License

523 stars 84 forks source link

Add hover byte status #502

Closed tomilho closed 4 months ago

tomilho commented 5 months ago

Adds Hover: 0/0x00 to the left of the selectionCount state. I labeled it with Hover: to easily distinguish from the selectionCount state. Closes #467

hover

connor4312 commented 5 months ago

Thanks for the PR! Instead of the current display, I think we should make the primary badge the hover state and show the selected in parenthesis similar to what is done for text editors:

So in the case:

Selection but no hover: just show 0x456 selected
Hover but no selection: 0x123
Both: 0x123 (0x456 selected)

tomilho commented 5 months ago

Thank you for the feedback. Just to double check I completely understand, we would have 2 badges:

In the primary badge, the hover state and the selected.
In the secondary badge, the focused state.

e.g)

Primary badge only: 0x123 (0x456 selected) or 0x123 or 0x456 selected
Secondary badge only: 0x789
Together: 0x123 (0x456 selected) 0x789 or 0x123 0x789 or 0x456 selected 0x789

tomilho commented 4 months ago

Here's visually what I was attempting to describe per the most recent commit: hover2

connor4312 commented 4 months ago

Looks great, thanks! Seems like we have a build pipeline issue right now but I'll that fixed and this merged in a day or two

tomilho commented 4 months ago

Thank you! 😀