search

microsoft / vscode-htmlhint

VS Code integration of HTMLHint, an HTML linter.
MIT License
50 stars 35 forks source link

Not working on VSCode Version 1.45.1 #74

Closed Pablodotnet closed 4 years ago

Pablodotnet commented 4 years ago

It is not recognizing the .htmlhintrc file on the latest version (1.45.1)

zhengmz commented 4 years ago

me too

jp7677 commented 4 years ago

Do you have by chance any htmlhint settings in your VS-Code settings file (.vscode/settings.json)? A PR of mine had been merged (https://github.com/microsoft/vscode-htmlhint/pull/70/files) but it should not have any effect in finding an existing .htmlhintrc file.

jp7677 commented 4 years ago

I have attached a PR which might fix this, the current code does not look for a .htmlhintrc file when htmlhint settings are set that does not override htmlhint configuration file or options. Would be cool if one of you could confirm that this fixes this issue.

Pablodotnet commented 4 years ago

Im not receiving the update

jp7677 commented 4 years ago

A new version has been published, could you please confirm that the issue is fixed (or not)?

Pablodotnet commented 4 years ago

Confirm that is working now 😄

jp7677 commented 4 years ago

Nice, thanks for the confirmation!