search

microsoft / vscode-iconv-lite-umd

A UMD version of iconv-lite to be used in VSCode.
MIT License
7 stars 7 forks source link

change signatures form Buffer to Uint8Array #3

Closed gyzerok closed 4 years ago

gyzerok commented 4 years ago

@bpasero as discussed in https://github.com/microsoft/vscode/pull/100539

bpasero commented 4 years ago

@gykuma can you also make this change for the encode and decode methods?

gyzerok commented 4 years ago

Be warned though, I didn't check if anything will break for any other methods except the ones we are using for the encoding 😄