search

microsoft / vscode-java-debug

Java Debugger for Visual Studio Code.
Other
529 stars 339 forks source link

Hot Code replacement popup - "Don't show again"-button doesn't work #1039

Open mojo2012 opened 3 years ago

mojo2012 commented 3 years ago

The button Don't show again button of the "hot code replacement warning" dialog doesn't work correctly. It always keeps reappearing. Furthermore multiple warnings are shown next to each other - which is a total overkill. At least the dialogs should be replaced, better even would be to hide them after some time (an assume the default action).

Environment
Steps To Reproduce
  1. Change code in a running app, that causes the popup to appear
  2. Click Don't show again
  3. Change code in a running app, that causes the popup to appear
Current Result

Popup is shown again, despite the fact that I clicked Don't show again

Expected Result

Popup does never ever again appear.

testforstephen commented 3 years ago

Currently "Don't show again" button is only taking effect in current debug session. And this button only suppresses the cause of the same failure in the current debug session. Once the debug session is terminated, it will clear the "Don't show again" status, and reappear again with a new debug session.

When HCR fails, reporting failure is necessary. Suppressing it forever might not be a good idea.