search

microsoft / vscode-java-debug

Java Debugger for Visual Studio Code.
Other
530 stars 339 forks source link

Changes that will allow an array of envFile locations to be defined #1506

Closed hildo closed 2 months ago

hildo commented 2 months ago

Changes for issue #1505

hildo commented 2 months ago

Is there something I can do to help here? I don't understand why my changes would be causing these failures? It looks like it is related to this step?

image
hildo commented 2 months ago

It looks like the tool being used (vsce) needs NodeJS minimum version 20, and the build pipeline is using version 16? image Should Node be upgraded?

hildo commented 2 months ago

@jdneo @testforstephen I have attempted to update the CI build to use NodeJS version 20, with the hope that the build issues will be addressed. Could someone please approve the workflow so we can see if the changes were sufficient? If I understand correctly, the workflow approval is not Pull Request approval, and just running the pipeline against this feature branch.

testforstephen commented 2 months ago

please also update the envFile's type definition (should be ["array", "string"]) in package.json and description in package.nls.json

https://github.com/microsoft/vscode-java-debug/blob/4a903c4c3c43e3072dc5381cd224170f37799631/package.json#L488-L489

And https://github.com/microsoft/vscode-java-debug/blob/4a903c4c3c43e3072dc5381cd224170f37799631/package.nls.json#L21

hildo commented 2 months ago

Of course. Thank you for the review. Please let me know if I have done them correctly (I am not 100% sure that my changes to package.json are correct).

testforstephen commented 2 months ago

@hildo thanks for contribution.

hildo commented 2 months ago

Thank you!