search

microsoft / vscode-java-dependency

Manage Java projects in Visual Studio Code.
https://marketplace.visualstudio.com/items?itemName=vscjava.vscode-java-dependency
MIT License
152 stars 74 forks source link

feat: Introduce a setting to control whether non-Java resources should be filtered #749

Closed jdneo closed 1 year ago

jdneo commented 1 year ago

See:

https://user-images.githubusercontent.com/6193897/231690524-4bfd3060-e039-43b7-8df3-a6e737b43499.mp4

The next step is add a button to quickly switch the behavior. It's not implemented yet due to an issue in VS Code: https://github.com/microsoft/vscode/issues/179842

jdneo commented 1 year ago

People from VS Code says that it is by design that the property of an object setting will not have the setting change update event: https://github.com/microsoft/vscode/issues/179842#issuecomment-1507123081

If we want to expose this setting to a command, we need to change it.

I'm thinking to change it to: java.project.explorer.showNonJavaResources. Will append a commit to address that.

jdneo commented 1 year ago

New UX: Give up using two commands toggling each other. Now using a static command to control all the filters in case that in the future new filters will be added.

https://user-images.githubusercontent.com/6193897/231926944-794b2f75-2d40-4ae3-bb83-3cb83f64c3f5.mp4