'java.configuration.runtimes' seems to be shared accross different projects in different devcontainers when they run concurrently (and I think they should be independent).

tchinchow commented 1 year ago

The bug / what is happening:

When I try to open 2 different projects:

using 2 different devcontainer definitions,
- using 2 different base docker containers each with 2 different versions of java
- (re)defining specific "java.configuration.runtimes" for both devcontainers

then I'd expect that "java.configuration.runtimes" to be different in both dev containers and match the java version installed in the corresponding container.

However, something strange and rather buggy happens instead:

When I get one container working, I get the following error in the OTHER container:

In the above message the JDK path is that of the first container and

NEITHER the one I defined for the second container,
NOR the one I'd expect when I'm running the second container.

I simply don't know what it is doing there and cannot find any reference to it in the second project.

I can have one or the other container working by cleaning the java server workspace but never both at once.

Even stranger:

When I choose "Open Settings" on that notification / pop-up dialog, then

Select "Remote (dev container)" tab
click "Edit in settings.json"
vscode magically opens a settings.json file
I confirm that the settings are indeed not following those specified in the devcontainer.json of the current container !
I Modify the settings.json that was automagically opened and MAKE it match the expected value for its devcontainer specification
Then I get the error message on the other running container !!! It really seems like the other container take the modification for itself as well and now complains that its java runtime does not exist (but it was working before the modification made in the other container !)

Conclusion: They seem to share the setting but I do not understand why ? and I believe that the should not !

Misc information

VSCode Version: 1.77.3
Local OS Version: Windows 10 (10.0.1045 Build 19045)
Docker Desktop version: 4.17.1
Remote OS Version: custom docker image based on Rocky8.7
Remote Extension/Connection Type: Containers

Steps to Reproduce:

Create 2 projects using devcontainers and using with different JDKs:

It is important to note that both devcontainers use

different base containers, AND
different devcontainer.json with
different java.configuration.runtimes settings

dev environment #1:

{
   ...
   "name": "dev container #1",
   "build": {
       ...
       "target": "my-builder-java8-oracle"
   },
   ...
   "customizations": {
       "vscode": {
           "settings": {
               "java.jdt.ls.java.home": "/usr/lib/jvm/java-17-openjdk-17.0.6.0.10-3.el8_7.x86_64",
               // "java.configuration.maven.globalSettings": "/fit-src/settings.xml",
               "java.configuration.maven.userSettings": "/fit-src/settings.xml",
               "java.configuration.runtimes": [
                   {
                     "name": "JavaSE-1.8",
                     "path": "/usr/java/jdk1.8.0_351-amd64",
                     "default": true
                   }, {
                     "name": "JavaSE-17",
                     "path": "/usr/lib/jvm/java-17-openjdk-17.0.6.0.10-3.el8_7.x86_64"
                   }
               ],
               // Setting `maven.executable.options` would help with Microsoft "vscode-maven" extension but not with the CLI.
               // see "postCreateCommand" section below.
               // "maven.executable.options": "-o -s /fit-src/settings.xml -Dmaven.repo.local=/fit-src/maven-repo",
               "maven.settingsFile": "/my-project/settings.xml",
               "redhat.telemetry.enabled": false
           },
           "extensions": [
               "ms-azuretools.vscode-docker",
               "redhat.java",
               "VisualStudioExptTeam.intellicode-api-usage-examples",
               "VisualStudioExptTeam.vscodeintellicode",
               "vscjava.vscode-java-debug",
               "vscjava.vscode-java-dependency",
               "vscjava.vscode-java-pack",
               "vscjava.vscode-java-test",
               "vscjava.vscode-maven"
           ]
       }
   }
}

and dev environment #1:

{
   NOTE: same as above just modify the jre 1.8 path to match that of the container
   ...
   "name": "dev container #2",
   "build": {
       ...
       "target": "my-builder-java8-openjdk"
   },
   ...
   "customizations": {
       "vscode": {
           "settings": {
               "java.jdt.ls.java.home": "/usr/lib/jvm/java-17-openjdk-17.0.6.0.10-3.el8_7.x86_64",
               // "java.configuration.maven.globalSettings": "/fit-src/settings.xml",
               "java.configuration.maven.userSettings": "/fit-src/settings.xml",
               "java.configuration.runtimes": [
                   {
                     "name": "JavaSE-1.8",
                     "path": "/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.362.b09-2.el8_7.x86_64",
                     "default": true
                   }, {
                     "name": "JavaSE-17",
                     "path": "/usr/lib/jvm/java-17-openjdk-17.0.6.0.10-3.el8_7.x86_64"
                   }
               ],
               // Setting `maven.executable.options` would help with Microsoft "vscode-maven" extension but not with the CLI.
               // see "postCreateCommand" section below.
               // "maven.executable.options": "-o -s /fit-src/settings.xml -Dmaven.repo.local=/fit-src/maven-repo",
               "maven.settingsFile": "/my-project/settings.xml",
               "redhat.telemetry.enabled": false
           },
           "extensions": [
               "ms-azuretools.vscode-docker",
               "redhat.java",
               "VisualStudioExptTeam.intellicode-api-usage-examples",
               "VisualStudioExptTeam.vscodeintellicode",
               "vscjava.vscode-java-debug",
               "vscjava.vscode-java-dependency",
               "vscjava.vscode-java-pack",
               "vscjava.vscode-java-test",
               "vscjava.vscode-maven"
           ]
       }
   }
}

I'm not sure of what extension is causing this... Who is using the "java.configuration.runtimes" settings ?

jdneo commented 1 year ago

This setting is consumed by the extension redhat.java.

I'll try to repro it when I have time. At the meantime, could you please check if you have defined java.configuration.runtimes in somewhere else? This setting's scope is machine-overidable, according to VS Code document, it can be overridden by workspace or folder settings.

tchinchow commented 1 year ago

Thanx @jdneo for your time and help.

According to what I see in the vscode settings dialog (inside the container), the java.configuration.runtimes setting is

not user defined.
defined in Remote (this is the one that (I suppose) should come from the devcontainer.json specification but actually seems to change when other containers modify them internally as well)
there's something in the "workspace settings" but it looks empty when I try to edit it... that may be related to the fact that it comes wrong when I boot the container and have to force/edit it through the settings ... not sure

I have created the issue report / call for help ;) in redhat.java

Many many thanx again. vscode is a great tool !

tchinchow commented 1 year ago

I'll close the issue since I opened another ticket elsewhere.

microsoft / vscode-java-dependency