search

microsoft / vscode-java-dependency

Manage Java projects in Visual Studio Code.
https://marketplace.visualstudio.com/items?itemName=vscjava.vscode-java-dependency
MIT License
140 stars 68 forks source link

creates file watcher with trailing slash causes problems for other extensions #828

Closed martinlippert closed 2 months ago

martinlippert commented 2 months ago

Investigating https://github.com/microsoft/vscode-spring-boot-dashboard/issues/324 and https://github.com/spring-projects/sts4/issues/1231 revealed that the Project Manager for Java extension in VSCode seems to create a file watcher that contains a trailing slash for the root path, which should not be done (according to https://github.com/spring-projects/sts4/issues/1231#issuecomment-2061156798).

It causes problems down the road with other extensions, since future file events when contain a wrong URI for the changed file, containing a duplicated / between the root path and the relative file path in the workspace.

martinlippert commented 2 months ago

@testforstephen Would be awesome if you could have a look.

testforstephen commented 2 months ago

this has been fixed in the pre-release version 0.23.2024041907 of Project Manager for Java extension. feel free to have a try.

martinlippert commented 2 months ago

LGTM, thanks for this fix. Much appreciated.