The split2 module is very slow when handling large amounts of CDP data

microsoft / vscode-js-debug

A DAP-compatible JavaScript debugger. Used in VS Code, VS, + more

MIT License

1.67k stars 283 forks source link

The split2 module is very slow when handling large amounts of CDP data #2001

Closed connor4312 closed 6 months ago

connor4312 commented 6 months ago

I noticed in a profile that the split2 module took a ridiculous amount of time when requesting a large source from a debugee:

Let's replace it with the optimized splitter I wrote for VS Code

andreamah commented 5 months ago

Are there verification steps for this?

connor4312 commented 5 months ago

No good steps really, but folks have been using js-debug-nightly for copilot-chat where this was an issue and it seems to have worked, so I'll mark verified.