microsoft / vscode-js-debug

A DAP-compatible JavaScript debugger. Used in VS Code, VS, + more
MIT License
1.67k stars 283 forks source link

fix: don't inject NODE_OPTIONS in Deno #2080

Closed lucacasonato closed 2 months ago

lucacasonato commented 2 months ago

In Deno 2, Deno has a process global. Because of this this extension tries to inject environment variables into the process through the inspector using process.env. However when running Deno without I/O permissions (the default), accessing process.env.* will show a permission prompt. This is confusing for users, as their code did not trigger this prompt, but the extensions' injected code did.

Because this code doesn't do anything in Deno anyway (because we do not respect NODE_OPTIONS), there is no point in running it in Deno at all. This commit disables this injection code path in Deno through environment detection.