microsoft / vscode-js-debug

A DAP-compatible JavaScript debugger. Used in VS Code, VS, + more
MIT License
1.67k stars 281 forks source link

v4.12.9 - Debugger for Chrome extension with angular9 lunching the page very slowly #686

Closed AvshT closed 4 years ago

AvshT commented 4 years ago

VS Code Version: 1.46.1+ Angular 9.1.12

If you go to the previous version, it working fine.

My assume is that you've remove the type:"chrome" option from launch.json And the use of type: "pwa-chrome" is not working as expected.

Any code recompile cause the slowness reload.

Please fix it ASAP.

roblourens commented 4 years ago

cc @connor4312

connor4312 commented 4 years ago

This may be the same as https://github.com/microsoft/vscode-js-debug/issues/598

Please try our nightly build to see if that fixes it for you!

waldnercharles commented 4 years ago

I've run into this issue as well; downgrading to 4.12.8 works if you don't want to upgrade to nightly.

chucknelson commented 4 years ago

VS Code Version: 1.47.3 Angular 8.0.0

Experiencing the same issue with an Angular 8 project, in addition to breakpoints no longer working (although in the logs, it looks like sourcemaps are resolving correctly).

Also able to restore working behavior by rolling back to version 4.12.8 of the extension.

connor4312 commented 4 years ago

@chucknelson this should be fixed in https://github.com/microsoft/vscode-js-debug/issues/598

Please try our nightly build to see if that fixes it for you!

chucknelson commented 4 years ago

Thanks @connor4312 - saw the note above but I don't think I was realizing the connection between vscode-js-debug and this extension! I'll try this out and update here.

I guess the latest version of the Chrome Debugger (4.12.9) is defaulting to use this new debugging backend...differently than 4.12.8? I'll have to look again so I can get this straight in my head...

chucknelson commented 4 years ago

@connor4312 - Alright, so after some more trial and error:

@roblourens , @connor4312 - Anyway, for this particular issue, I would vote to close it since it's caused by js-debug, and has already been fixed in nightly.