Opening multiple large .cpuprofile files seems to crash the webview

microsoft / vscode-js-profile-visualizer

A custom editor for viewing `.cpuprofile` files in VS Code

MIT License

139 stars 29 forks source link

Opening multiple large .cpuprofile files seems to crash the webview #152

Closed TwitchBronBron closed 5 months ago

TwitchBronBron commented 11 months ago

I have some fairly large cpuprofile files. Opening the first one works, but when I go to open the second one, it goes to a blank screen. Is there some memory or CPU limitation in the webviews that's causing this?

The vscode devtools seem to disconnect the moment the webview goes to the grey screen.

File 1: 1698236592187-bsc-profile-1698236556798.cpuprofile
File 2: 1698236759491-bsc-profile-1698236712733.cpuprofile

connor4312 commented 11 months ago

Yep, that looks like an OOM crash

TwitchBronBron commented 9 months ago

Is there anything that can be done to help mitigate this? Like:

storing certain items in a more efficient fashion in memory (like bitmaps instead of integers or strings for certain things)
storing the item "server side" (i.e. in the vscode process instead of the webview) and streaming them in chunks to the UI?
not rendering all of the results at one time in the UI? (like virtual scrolling).

connor4312 commented 5 months ago

Fixed in the latest VS Code Insiders