fix: make heap snapshot graph a panel instead of an editor

microsoft / vscode-js-profile-visualizer

A custom editor for viewing `.cpuprofile` files in VS Code

MIT License

139 stars 29 forks source link

fix: make heap snapshot graph a panel instead of an editor #179

Closed connor4312 closed 5 months ago

connor4312 commented 6 months ago

It's not valid to open a file directly versus focusing a single element. Make it a webview panel instead to avoid the usability issue.

Fixes #175

IanButterworth commented 5 months ago

@connor4312 I just updated to v1.0.9 and the open file dialog issue is fixed but clicking on the graph icons I see the raw json rather than the graph

connor4312 commented 5 months ago

You'll also need to be on Insiders, as the table is a built-in extension and not marketplace updatable. I should fix that to prevent users getting the updated flame graph code on stable to avoid this situation...