search

microsoft / vscode-jshint

VSCode extension to integrate jshint into VSCode
https://marketplace.visualstudio.com/items?itemName=dbaeumer.jshint
MIT License
72 stars 48 forks source link

Avoid using rootPath #81

Open roblourens opened 4 years ago

roblourens commented 4 years ago

This extension appears to be using rootPath from the LSP. This is a deprecated property that may not work as expected in a multi-root workspace.

See this guide on implementing multi-root support: https://github.com/Microsoft/vscode/wiki/Adopting-Multi-Root-Workspace-APIs#language-client--language-server

https://github.com/microsoft/vscode/issues/69335

gjsjohnmurray commented 3 years ago

@RMacfarlane it would be nice to get this resolved so the related VS Code issue has one less popular extension to worry about breaking.