microsoft / vscode-jupyter

VS Code Jupyter extension
https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter
MIT License
1.25k stars 276 forks source link

Broken link formatting in the Czech localisation #11937

Open mmotejlek opened 1 year ago

mmotejlek commented 1 year ago

Applies To

What happened?

The Czech localisation file package.nls.cs.json contains many links which have a space between the brackets containing text and the link address (e.g. [protokolu] (command:jupyter.viewOutput) instead of [protokolu](command:jupyter.viewOutput)), so they are not recognized as links and are incorrectly displayed (for example in error messages).

I'm aware that the file package.nls.cs.json isn't in this repository, but I wasn't able to figure out where it comes from.

VS Code Version

1.73.0

Jupyter Extension Version

2022.9.1202862440

Jupyter logs

No response

Coding Language and Runtime Version

No response

Language Extension Version (if applicable)

2022.18.1

Anaconda Version (if applicable)

No response

Running Jupyter locally or remotely?

No response

amunger commented 1 year ago

the file comes from language packs that can be installed from the marketplace like https://marketplace.visualstudio.com/items?itemName=MS-CEINTL.vscode-language-pack-cs

We can help prevent this on our side by improving out localization strings though:

localize(
  '...',
  'Blah blah {0} blah blah',
  `[${localize('...', 'linktext')}](link)`
)
mmotejlek commented 1 year ago

Thanks for the response! Shall I create an issue in microsoft/vs_loc for now?

amunger commented 1 year ago

yes, that looks like the right place

mmotejlek commented 1 year ago

Issue fixed.

Not closing yet because of your suggestion.