microsoft / vscode-jupyter

VS Code Jupyter extension
https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter
MIT License
1.29k stars 290 forks source link

color theme customization is not supported #1358

Closed stevenlis closed 3 years ago

stevenlis commented 5 years ago

color theme customization (like non-italic) is no longer working in the interactive window after the new update.

Snipaste_905

The Type code here and press shift-enter to run is also italic now for some reason.`

The color theme I'm using is https://github.com/Binaryify/OneDark-Pro

Extension: 2019.10.41019 (8 October 2019)
Version: 1.39.0 (user setup)
Commit: 9df03c6d6ce97c6645c5846f6dfa2a6a7d276515
Date: 2019-10-09T06:58:04.439Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18362
rchiodo commented 5 years ago

Thanks this helps. We made a modification such that we use the font settings from VS code as the default values for fonts in the interactive window. This is likely messing up your theme.

The input 'type code here and press shift-enter' should have been italic before though. It's just a larger font now.

rchiodo commented 5 years ago

In my editor, the import statements are italic. So the interactive window matches:

image

Do you have some other setting that forces your editor to not show italics?

rchiodo commented 5 years ago

I tried customizing my color theme in my settings, and yes this doesn't come out in the interactive window, but it didn't before either. I installed our last version and theme customization didn't work there either.

stevenlis commented 5 years ago

my bad. I should've made it clear. I have the following in my setting.

 "editor.tokenColorCustomizations": {
        "textMateRules": [
            {
                "name": "Non italic",
                "scope": [
                    "comment",
                    "punctuation.definition.comment",
                    "comment.line.double-slash",
                    "comment.block.documentation",
                    "keyword.control.import.python",
                    "keyword.control.flow.python",
                    "variable.parameter"
                ],
                "settings": {
                    "fontStyle": ""
                }
            }
        ]
    }
rchiodo commented 5 years ago

Thanks that helps. This has never worked AFAIK. Here's the same thing with the August version of the extension:

image

stevenlis commented 5 years ago

@rchiodo seems you're right... for whatever reasons I noticed this time.. lol..