search

microsoft / vscode-jupyter

VS Code Jupyter extension
https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter
MIT License
1.29k stars 292 forks source link

Kubeflow Authentication breaks with JupyterLab 4 #15659

Open TobiasGoerke opened 6 months ago

TobiasGoerke commented 6 months ago

With JupyterLab 4.x the /tree path returns a 404 for some reason. This breaks iff authenticating with a Kubeflow instance in getXSRFToken (link), as the result is expected to be a http 200.

This only applies to Kubeflow instances, for which the sessionCookie param is used see line 205.

I've tried using tokenUrl = new URL('lab', addTrailingSlash(url)).toString(); instead, which works great for JupyterLab 4 Notebooks hosted on Kubeflow.

I'll happily create a PR if this is an appropriate fix. Thanks!

DonJayamanne commented 3 months ago

I'll happily create a PR if this is an appropriate fix. Thanks!

@TobiasGoerke Please feel free to create a PR, and I'll help with that.