microsoft / vscode-jupyter

VS Code Jupyter extension
https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter
MIT License
1.3k stars 293 forks source link

If XDG_DATA_HOME is configured without JUPYTER_DATA_DIR, the app doesn't appear to find kernels #15735

Open randallb opened 6 months ago

randallb commented 6 months ago

Applies To

What happened?

When XDG_DATA_HOME is configured (seemingly without JUPYTER_DATA_DIR) on unix, the plugin fails to properly detect kernels.

https://github.com/microsoft/vscode-jupyter/blob/f41cffb91a1853a639ae7b29f50072126cb0e459/src/kernels/raw/finder/jupyterPaths.node.ts#L32

https://github.com/bolt-foundry/vscode-jupyter/blob/main/build/installDenoKernel.ts#L10

https://github.com/microsoft/vscode-jupyter/blob/f41cffb91a1853a639ae7b29f50072126cb0e459/src/kernels/raw/finder/jupyterPaths.node.unit.test.ts#L251-L260

I think those are the related callsites / tests. I didn't feel familiar enough to try a PR, but am happy to do so.

VS Code Version

1.89

Jupyter Extension Version

v2024.4.0

Jupyter logs

No response

Coding Language and Runtime Version

deno

Language Extension Version (if applicable)

No response

Anaconda Version (if applicable)

No response

Running Jupyter locally or remotely?

Local

DonJayamanne commented 4 months ago

Thanks for filing this issue and sorry you are running into this & sorry you are running into this. Lets first try to get to the bottom of the issue, based on your description some kernels aren't getting detected. However the code you have highlighted doesn't seem to be causing any issues.

Please could you

ms-toolsai-jupyter-insiders.vsix (3).zip