search

microsoft / vscode-jupyter

VS Code Jupyter extension
https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter
MIT License
1.3k stars 293 forks source link

try delegating even if we cannot get the full info #16057

Closed amunger closed 1 month ago

amunger commented 1 month ago

Fixes https://github.com/microsoft/vscode-jupyter/issues/16026

We add the context menu command only if we decide that the variable can support a Data viewer, so it seems pretty safe to try and delegate the Data viewer command out even if we can't get the type info at that moment.

pwang347 commented 1 month ago

Hi @amunger, thanks for looking into this! Do you know if this fixes https://github.com/microsoft/vscode-data-wrangler/issues/285 as well?

amunger commented 1 month ago

@pwang347 - It will now call the DW command in that case, where it didn't before, but DW fails to open the viewer with Could not retrieve variable <MyEnum.ONE: 1> from the Jupyter extension. Please file an issue on the Data Wrangler GitHub repository.

info we are passing: {"name":"<MyEnum.ONE: 1>","count":0,"shape":"","size":0,"supportsDataExplorer":false,"value":"...","truncated":true,"frameId":9}

for some reason, the name from the context does not include the parent variable d on that variable, which may be an issue with debugpy