microsoft / vscode-jupyter

VS Code Jupyter extension
https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter
MIT License
1.3k stars 294 forks source link

Choosing a kernel for the first time does not cause a kernel change event #16112

Open imadjarov-quantinuum opened 1 month ago

imadjarov-quantinuum commented 1 month ago

Applies To

What happened?

This is related to the recently closed https://github.com/microsoft/vscode-jupyter/pull/15967 (@rchiodo @DonJayamanne)

When choosing a kernel for a notebook that has had no previous kernel selected, a "kernel change event" (as discussed in the issue above) is not fired. For example, Pylance (v2024.10.1) does not start highlighting syntax with the newly selected kernel. Only once another kernel is selected again does this event fire and Pylance starts highlighting code. It seems like the above bugfix only works once you select a kernel more than once.

I am running this via SSH Remote btw.

VS Code Version

1.94.0

Jupyter Extension Version

2024.9.1

Jupyter logs

No response

Coding Language and Runtime Version

Python

Language Extension Version (if applicable)

2024.16.0

Anaconda Version (if applicable)

No response

Running Jupyter locally or remotely?

Remote

DonJayamanne commented 3 weeks ago

@rchiodo I'm struggling to understand this issue here. If no kernel was ever selected, then selecting a kernel will definitely cause a change event as there was no information to start with.

@imadjarov-quantinuum Please can you install the latest pre-release versions of Jupyter and Pylance and confirm this works.

rchiodo commented 3 weeks ago

@DonJayamanne I haven't seen this myself. Does jupyter log the get kernel request? Pylance does not, it just makes the call when getting the python path for a file.

imadjarov-quantinuum commented 3 weeks ago

@rchiodo I'm struggling to understand this issue here. If no kernel was ever selected, then selecting a kernel will definitely cause a change event as there was no information to start with.

@imadjarov-quantinuum Please can you install the latest pre-release versions of Jupyter and Pylance and confirm this works.

I upgraded to VS Code 1.95.1, and the pre-release versions of both Jupyter and Pylance, and the issue persists.