microsoft / vscode-jupyter

VS Code Jupyter extension
https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter
MIT License
1.3k stars 293 forks source link

findMatchBorderHighlight does not highlight correct borders #5350

Closed alexdauenhauer closed 3 years ago

alexdauenhauer commented 3 years ago

Environment data

Expected behaviour

editor.findMatchBorder would properly highlight the match borders

Actual behaviour

borders drawn are incorrect image

Steps to reproduce:

[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

  1. open a notebook. Highlight a word or variable you want to highlight and see the border match fail

Logs

Output for Jupyter in the Output panel (ViewOutput, change the drop-down the upper-right of the Output panel to Jupyter)

``` User belongs to experiment group 'jupyterTestcf' User belongs to experiment group 'pythonDiscoveryModulecf' User belongs to experiment group 'NativeNotebookEditor' Error 2021-03-29 10:57:16: Jupyter Kernel Spec not found for a local connection > ~/.pyenv/versions/mercury/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py -c "import jupyter" > ~/.pyenv/versions/mercury/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py -c "import notebook" > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py pip list > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py -c "import ipykernel" > ~/.pyenv/versions/mercury/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py jupyter kernelspec --version > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py -c "import ipykernel" > ~/.pyenv/versions/mercury/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py vscode_datascience_helpers.daemon --daemon-module=vscode_datascience_helpers.jupyter_daemon -v > ~/.pyenv/versions/mercury/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py vscode_datascience_helpers.daemon --daemon-module=vscode_datascience_helpers.jupyter_daemon -v > ~/.pyenv/versions/mercury/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py vscode_datascience_helpers.daemon --daemon-module=vscode_datascience_helpers.jupyter_daemon -v > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py -c "import ipykernel" > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py vscode_datascience_helpers.daemon --daemon-module=vscode_datascience_helpers.kernel_launcher_daemon -v > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py vscode_datascience_helpers.daemon --daemon-module=vscode_datascience_helpers.kernel_launcher_daemon -v Started kernel Python 3.8.6 64-bit ('qs') > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py -c "import ipykernel" > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py -c "import ipykernel" > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py vscode_datascience_helpers.daemon --daemon-module=vscode_datascience_helpers.kernel_launcher_daemon -v > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py -c "import ipykernel" > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py pip list > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py -c "import ipykernel" > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py -c "import ipykernel" > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py -c "import ipykernel" > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py vscode_datascience_helpers.daemon --daemon-module=vscode_datascience_helpers.kernel_launcher_daemon -v > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py -c "import ipykernel" > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py vscode_datascience_helpers.daemon --daemon-module=vscode_datascience_helpers.kernel_launcher_daemon -v > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py -c "import ipykernel" > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py -c "import ipykernel" > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py vscode_datascience_helpers.daemon --daemon-module=vscode_datascience_helpers.kernel_launcher_daemon -v > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py -c "import ipykernel" > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py -c "import ipykernel" > ~/.pyenv/versions/qs/bin/python ~/.vscode/extensions/ms-toolsai.jupyter-2021.3.684299474/pythonFiles/pyvsc-run-isolated.py vscode_datascience_helpers.daemon --daemon-module=vscode_datascience_helpers.kernel_launcher_daemon -v ```

joyceerhl commented 3 years ago

Sorry for the trouble @alexdauenhauer. Although this seems to be working for me: image

Did you have to work in this notebook for some time before this behavior appeared?

greazer commented 3 years ago

Closing as this is an upstream VS Code bug.