Don't notify the user to reload after installing the extension

[digitarald]

Python (or Jupyter?) does its own reload after install prompt:

(the screenshot is from usertesting but I had no luck reproducing this for myself)

It would be great if it was left to VS Code to handle the reload, so extensions don't run extra notifications. If there are edge cases that VS Code doesn't handle well or if the UX isn't obvious enough, we should improve those in VS Code to make this easier for all extensions.

[IanMatthewHuff]

@digitarald Thanks for filing. I do think we could probably handle this better. I believe there are a few edge cases that might not work in a specific open notebook or Interactive Window document. But this messaging is pretty non-standard. We might be able to winnow out those edge cases or if not, just go ahead and have VS Code do a full reload.

Might is probably never a good thing to have in a message.

[greazer]

We should eliminate this message box from needing to be shown by scanning our source for calls to the Python extension and testing to see whether those scenarios are working without having to reload VS Code. If so, then we can remove the message box.

[digitarald]

A proposal I discussed with @isidorn was that if the extension determines that it needs to reload, it should be handled by VS Code. Worst case would be that a user syncs multiple extensions into a fresh VS Code instance and multiple extensions prompting for restart, all with their own notification.

[Tyriar]

I just installed the python extension to try debug a python file without a launch config and I got this notification, I don't have any notebooks open so I don't know what it's talking about.

[IanMatthewHuff]

This was a duplicate of a previous issue that I cleaned up. The new logic is only to show this message if there is an active notebook or interactive window python kernel. In which case the warning seems reasonable.