search

microsoft / vscode-jupyter

VS Code Jupyter extension
https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter
MIT License
1.28k stars 290 forks source link

Implement Live Share for native interactive window #7460

Open joyceerhl opened 3 years ago

joyceerhl commented 3 years ago

Some people are still trying to use this https://github.com/MicrosoftDocs/live-share/issues/4032#issuecomment-914737341

TamirShklaz commented 3 years ago

+1 would really like this feature :)

rchiodo commented 2 years ago

This wouldn't likely be something the jupyter extension actually contributes. I believe it's entirely a live share thing.

lostintangent commented 2 years ago

Just to confirm: the previous interactive window was a Python extension feature? But now, the interactive window is a built-in primitive of VS Code? If so, then we may need to think through the APIs that Live Share would need to actually remote the context of this experience. Who would be the best person to connect with on that?

rchiodo commented 2 years ago

Yes the previous interactive window was a jupyter extension feature. We used the live share APIs to mimic execution across to the guest.

The new interactive window is a core component of VS code now. It's made up of a notebook and a standalone monaco editor. I'd imagine you'd only need to remote the notebook part (at least to start with).

@rebornix or me would be good people to talk to.

lostintangent commented 2 years ago

Live Share is already working on remoting the notebook experience, but it sounds like the interactive window is a separate component?

rchiodo commented 2 years ago

Yeah technically under the covers it's a notebook, but it's registered with different schemes and doesn't end up in the list of 'notebooks'.

lostintangent commented 2 years ago

I see. As long as Live Share could discover, inspect and "re-play" the actions of an interactive window notebook, then we should be able to add support for this 👍🏼

@rebornix Do you know whether there are already APIs that would allow Live Share to support this? Or do we need to brainstorm the new requirements?

// CC @daytonellwanger

rebornix commented 2 years ago

Under the hood the interactive window is a notebook + a text editor, and we can use the normal notebook API to drive its execution. It means it won't add too much work to get it working but right now we use API commands to create interactive window, instead of API, not so sure if it meets all requirements but we can explore @lostintangent

janyas188 commented 2 years ago

hi,

I was just wondering if this feature is likely to be bought back soon? I was hoping to use this feature to share an interactive window in my current project and would also be useful in other future projects?

rchiodo commented 2 years ago

@janyas188 I recommend commenting on the liveshare issue. We (the jupyter team) would likely not be implementing this.

MSA8D8 commented 1 year ago

I have the same issue here. https://github.com/MicrosoftDocs/live-share/issues/4032

This interactive window is really useful for me to write Python script. So, I wish you could do something to solve this.

The link rchiodo shared was no longer accessible https://github.com/microsoft/vssaas-planning/issues/5898