Move saving of plots into renderer extension & plot viewer as well

[DonJayamanne]

Suggestion:

• Move saving of plots from renderer into plot viewer
• Move plot viewer into renderer extension

why?

• Currently saving plots & opening plots in plot viewer requires users to install jupyter extension
• Thus renderer extension has a dependcy on jupyter extension for some features

Benefits

• Renderer extension doesn't need to rely on jupyter extension to enable some icons
• Users don't need jupyter extension installed to save/open plot viewer (generic features)

Draw back

• Could be deemed as bloatware in renderer extension

Alternatively we could have the image renderers duplicated in jupyter extension (feels silly to do that, having duplicate renderers, confuses users)

[amunger]

seems rare that someone would have our renderer extension without having the jupyter extension

[DonJayamanne]

@

[DonJayamanne]

@amunger this is an issue for debt that reduces complexity in our code

seems rare that someone would have our renderer extension without having the jupyter extension

Yes i agree , and thats a great reason to move most of the plot viewer code into the renderer extension. This way we have far fewer dependencies, smaller code base in jujpyter.

So this issue is more about changes to the code structure of Jupyter, not UI changes. I.e. i think this is a very useful change (move stuff out of the extension into renderer), faster builds, easier CG, etc This is one less dependency on react in our code base as well

[DonJayamanne]

I'd like to keep this open so we can work on this , unless you disagree with the suggested change. I don't see any comments about why such a chagne (debt) items is not good, hence re-opening this